Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding MetricNamespacesAPI for version 2017-12-01-preview/Fix metrics_API.json format issue #3804

Merged
merged 14 commits into from
Sep 6, 2018
Merged

Adding MetricNamespacesAPI for version 2017-12-01-preview/Fix metrics_API.json format issue #3804

merged 14 commits into from
Sep 6, 2018

Conversation

LarryZhang19
Copy link
Contributor

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Sep 4, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2761

@AutorestCI AutorestCI mentioned this pull request Sep 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 4, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Sep 4, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3521

@AutorestCI
Copy link

AutorestCI commented Sep 4, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2139

@AutorestCI AutorestCI mentioned this pull request Sep 4, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 4, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2631

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Sep 6, 2018
Merged
Merged
@annatisch
Copy link
Member

Thanks @LarryZhang19 - could you please fix the model validation error:

 error: 
operationId: MetricNamespaces_List
scenario: Get Metric Namespaces without filter
source: request
responseCode: ALL
severity: 0
errorCode: DOUBLE_FORWARD_SLASHES_IN_URL
errorDetails:
  code: DOUBLE_FORWARD_SLASHES_IN_URL
  id: OAV129
  message: >-
    In operation "MetricNamespaces_List", example for parameter "resourceUri":
    "/subscriptions/a252e87d-ec06-45b1-8901-57e613be91b0/resourceGroups/larrytest/providers/Microsoft.DocumentDB/databaseAccounts/larrytestdocdb"
    starts with a forward slash and the path template:
    "/{resourceUri}/providers/microsoft.insights/metricNamespaces" contains a
    forward slash before the parameter starts. This will cause double forward
    slashes  in the request url. Thus making it incorrect. Please rectify the
    example.
  innerErrors: !<tag:yaml.org,2002:js/undefined> ''

@LarryZhang19
Copy link
Contributor Author

Fixed the resource uri and pushed the change again.

@annatisch annatisch merged commit 5c3eebf into Azure:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch approved these changes

Assignees

@annatisch annatisch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LarryZhang19 @AutorestCI @azuresdkci @annatisch